Skip to content

Fix workflow syntax#2645

Merged
skedwards88 merged 2 commits intogithub:mainfrom
theirix:patch-1
Jan 23, 2021
Merged

Fix workflow syntax#2645
skedwards88 merged 2 commits intogithub:mainfrom
theirix:patch-1

Conversation

@theirix
Copy link
Copy Markdown
Contributor

@theirix theirix commented Jan 7, 2021

Steps must be a child of the build node, not the matrix

Why:

Workflow example has the wrong syntax.

What's being changed:

Fixed workflow syntax in a "Packaging workflow data as artifacts" section

Check off the following:

@theirix
Fix workflow syntax
c616276 
Steps must be a child of the build node, not the matrix
@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 7, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Copy Markdown
Contributor

janiceilene commented Jan 8, 2021

@theirix Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team actions This issue or pull request should be reviewed by the docs actions team labels Jan 8, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 16, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Jan 16, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 19, 2021
@janiceilene
Copy link
Copy Markdown
Contributor

janiceilene commented Jan 19, 2021

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@skedwards88 skedwards88 self-assigned this Jan 22, 2021
skedwards88
skedwards88 approved these changes Jan 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Thanks for fixing this! I'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Jan 23, 2021
@skedwards88 skedwards88 merged commit b8394fd into github:main Jan 23, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 23, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skedwards88 skedwards88 skedwards88 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skedwards88 skedwards88

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theirix @janiceilene @skedwards88 @jmarlena